gem5-dev@gem5.org

The gem5 Developer List

View all threads

[S] Change in gem5/gem5[develop]: tests: Enable build/ALL/gem5 supported-isas-check tests

BB
Bobby Bruce (Gerrit)
Thu, Sep 15, 2022 7:06 PM

Bobby Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/63332?usp=email )

Change subject: tests: Enable build/ALL/gem5 supported-isas-check tests
......................................................................

tests: Enable build/ALL/gem5 supported-isas-check tests

These tests were disabled until the build/ALL/gem5 compilation was
complete. These test the gem5.runtime.get_supported_isas function.

Change-Id: Ieac5676e9fed121f3cfe35e38f9748431824cbc0
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/63332
Maintainer: Jason Lowe-Power power.jg@gmail.com
Reviewed-by: Jason Lowe-Power power.jg@gmail.com
Tested-by: kokoro noreply+kokoro@google.com

M tests/gem5/multi_isa/test_multi_isa.py
1 file changed, 16 insertions(+), 4 deletions(-)

Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass

diff --git a/tests/gem5/multi_isa/test_multi_isa.py
b/tests/gem5/multi_isa/test_multi_isa.py
index 35de85b..4d7a18c 100644
--- a/tests/gem5/multi_isa/test_multi_isa.py
+++ b/tests/gem5/multi_isa/test_multi_isa.py
@@ -77,10 +77,6 @@
length=length_map[isa],
)

  • Remove this when the muli-isa work is incorporated.

build/ALL/gem5.opt

  • must be compilable.

  • continue
  • if isa != "null":
        # The null isa is not "supported" in a case where other ISAs are
        # present.
    

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/63332?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ieac5676e9fed121f3cfe35e38f9748431824cbc0
Gerrit-Change-Number: 63332
Gerrit-PatchSet: 4
Gerrit-Owner: Bobby Bruce bbruce@ucdavis.edu
Gerrit-Reviewer: Bobby Bruce bbruce@ucdavis.edu
Gerrit-Reviewer: Jason Lowe-Power power.jg@gmail.com
Gerrit-Reviewer: kokoro noreply+kokoro@google.com
Gerrit-MessageType: merged

Bobby Bruce has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/63332?usp=email ) Change subject: tests: Enable build/ALL/gem5 supported-isas-check tests ...................................................................... tests: Enable build/ALL/gem5 supported-isas-check tests These tests were disabled until the build/ALL/gem5 compilation was complete. These test the `gem5.runtime.get_supported_isas` function. Change-Id: Ieac5676e9fed121f3cfe35e38f9748431824cbc0 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/63332 Maintainer: Jason Lowe-Power <power.jg@gmail.com> Reviewed-by: Jason Lowe-Power <power.jg@gmail.com> Tested-by: kokoro <noreply+kokoro@google.com> --- M tests/gem5/multi_isa/test_multi_isa.py 1 file changed, 16 insertions(+), 4 deletions(-) Approvals: Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved kokoro: Regressions pass diff --git a/tests/gem5/multi_isa/test_multi_isa.py b/tests/gem5/multi_isa/test_multi_isa.py index 35de85b..4d7a18c 100644 --- a/tests/gem5/multi_isa/test_multi_isa.py +++ b/tests/gem5/multi_isa/test_multi_isa.py @@ -77,10 +77,6 @@ length=length_map[isa], ) - # Remove this when the muli-isa work is incorporated. `build/ALL/gem5.opt` - # must be compilable. - continue - if isa != "null": # The null isa is not "supported" in a case where other ISAs are # present. -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/63332?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ieac5676e9fed121f3cfe35e38f9748431824cbc0 Gerrit-Change-Number: 63332 Gerrit-PatchSet: 4 Gerrit-Owner: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Jason Lowe-Power <power.jg@gmail.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com> Gerrit-MessageType: merged