gem5-dev@gem5.org

The gem5 Developer List

View all threads

[S] Change in gem5/gem5[develop]: tests: Add 'requires' tests for ALL/gem5

BB
Bobby Bruce (Gerrit)
Thu, Sep 22, 2022 6:19 PM

Bobby Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/63433?usp=email )

(

4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
)Change subject: tests: Add 'requires' tests for ALL/gem5
......................................................................

tests: Add 'requires' tests for ALL/gem5

Change-Id: I58012b092dc1ec027474e2e45ad3e9809b31578b
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/63433
Maintainer: Jason Lowe-Power power.jg@gmail.com
Tested-by: kokoro noreply+kokoro@google.com
Reviewed-by: Jason Lowe-Power power.jg@gmail.com

M tests/gem5/stdlib/test_requires.py
1 file changed, 30 insertions(+), 0 deletions(-)

Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass

diff --git a/tests/gem5/stdlib/test_requires.py
b/tests/gem5/stdlib/test_requires.py
index a70ca6b..293eb3d 100644
--- a/tests/gem5/stdlib/test_requires.py
+++ b/tests/gem5/stdlib/test_requires.py
@@ -58,3 +58,20 @@
valid_isas=(isa_map[isa],),
length=length_map[isa],
)
+

  • if isa != "null":
  •    gem5_verify_config(
    
  •        name=f"requires-isa-{isa}-with-all-compiled",
    
  •        verifiers=(),
    
  •        fixtures=(),
    
  •        config=joinpath(
    
  •            config.base_dir,
    
  •            "tests",
    
  •            "gem5",
    
  •            "configs",
    
  •            "requires_check.py",
    
  •        ),
    
  •        config_args=["-i", isa],
    
  •        valid_isas=(constants.all_compiled_tag,),
    
  •        length=constants.quick_tag,
    
  •    )
    

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/63433?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I58012b092dc1ec027474e2e45ad3e9809b31578b
Gerrit-Change-Number: 63433
Gerrit-PatchSet: 9
Gerrit-Owner: Bobby Bruce bbruce@ucdavis.edu
Gerrit-Reviewer: Bobby Bruce bbruce@ucdavis.edu
Gerrit-Reviewer: Jason Lowe-Power power.jg@gmail.com
Gerrit-Reviewer: kokoro noreply+kokoro@google.com
Gerrit-MessageType: merged

Bobby Bruce has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/63433?usp=email ) ( 4 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: tests: Add 'requires' tests for ALL/gem5 ...................................................................... tests: Add 'requires' tests for ALL/gem5 Change-Id: I58012b092dc1ec027474e2e45ad3e9809b31578b Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/63433 Maintainer: Jason Lowe-Power <power.jg@gmail.com> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Jason Lowe-Power <power.jg@gmail.com> --- M tests/gem5/stdlib/test_requires.py 1 file changed, 30 insertions(+), 0 deletions(-) Approvals: Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved kokoro: Regressions pass diff --git a/tests/gem5/stdlib/test_requires.py b/tests/gem5/stdlib/test_requires.py index a70ca6b..293eb3d 100644 --- a/tests/gem5/stdlib/test_requires.py +++ b/tests/gem5/stdlib/test_requires.py @@ -58,3 +58,20 @@ valid_isas=(isa_map[isa],), length=length_map[isa], ) + + if isa != "null": + gem5_verify_config( + name=f"requires-isa-{isa}-with-all-compiled", + verifiers=(), + fixtures=(), + config=joinpath( + config.base_dir, + "tests", + "gem5", + "configs", + "requires_check.py", + ), + config_args=["-i", isa], + valid_isas=(constants.all_compiled_tag,), + length=constants.quick_tag, + ) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/63433?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I58012b092dc1ec027474e2e45ad3e9809b31578b Gerrit-Change-Number: 63433 Gerrit-PatchSet: 9 Gerrit-Owner: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Jason Lowe-Power <power.jg@gmail.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com> Gerrit-MessageType: merged