gem5-dev@gem5.org

The gem5 Developer List

View all threads

[S] Change in gem5/gem5[develop]: configs: bug fix for misc node distribution

DY
Daecheol You (Gerrit)
Fri, Sep 23, 2022 1:53 AM

Daecheol You has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/63731?usp=email )

Change subject: configs: bug fix for misc node distribution
......................................................................

configs: bug fix for misc node distribution

Wrong parameter is removed from the distributeNodes calling

Change-Id: I84cdf3e993d6b7852c4f134441d77a4b295e8574
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/63731
Maintainer: Jason Lowe-Power power.jg@gmail.com
Tested-by: kokoro noreply+kokoro@google.com
Reviewed-by: Jason Lowe-Power power.jg@gmail.com
Reviewed-by: Tiago Muck tiago.muck@arm.com

M configs/topologies/CustomMesh.py
1 file changed, 17 insertions(+), 1 deletion(-)

Approvals:
Tiago Muck: Looks good to me, approved
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass

diff --git a/configs/topologies/CustomMesh.py
b/configs/topologies/CustomMesh.py
index 2e10fdc..545ba4b 100644
--- a/configs/topologies/CustomMesh.py
+++ b/configs/topologies/CustomMesh.py
@@ -357,7 +357,7 @@
self.distributeNodes(hnf_params, hnf_nodes)

      # Place CHI_MN on the mesh
  •    self.distributeNodes(options, mn_params, mn_nodes)
    
  •    self.distributeNodes(mn_params, mn_nodes)
    
        # Place CHI_SNF_MainMem on the mesh
        self.distributeNodes(mem_params, mem_nodes)
    

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/63731?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I84cdf3e993d6b7852c4f134441d77a4b295e8574
Gerrit-Change-Number: 63731
Gerrit-PatchSet: 2
Gerrit-Owner: Daecheol You daecheol.you@samsung.com
Gerrit-Reviewer: Daecheol You daecheol.you@samsung.com
Gerrit-Reviewer: Jason Lowe-Power jason@lowepower.com
Gerrit-Reviewer: Jason Lowe-Power power.jg@gmail.com
Gerrit-Reviewer: Tiago Muck tiago.muck@arm.com
Gerrit-Reviewer: kokoro noreply+kokoro@google.com
Gerrit-MessageType: merged

Daecheol You has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/63731?usp=email ) Change subject: configs: bug fix for misc node distribution ...................................................................... configs: bug fix for misc node distribution Wrong parameter is removed from the distributeNodes calling Change-Id: I84cdf3e993d6b7852c4f134441d77a4b295e8574 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/63731 Maintainer: Jason Lowe-Power <power.jg@gmail.com> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Jason Lowe-Power <power.jg@gmail.com> Reviewed-by: Tiago Muck <tiago.muck@arm.com> --- M configs/topologies/CustomMesh.py 1 file changed, 17 insertions(+), 1 deletion(-) Approvals: Tiago Muck: Looks good to me, approved Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved kokoro: Regressions pass diff --git a/configs/topologies/CustomMesh.py b/configs/topologies/CustomMesh.py index 2e10fdc..545ba4b 100644 --- a/configs/topologies/CustomMesh.py +++ b/configs/topologies/CustomMesh.py @@ -357,7 +357,7 @@ self.distributeNodes(hnf_params, hnf_nodes) # Place CHI_MN on the mesh - self.distributeNodes(options, mn_params, mn_nodes) + self.distributeNodes(mn_params, mn_nodes) # Place CHI_SNF_MainMem on the mesh self.distributeNodes(mem_params, mem_nodes) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/63731?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I84cdf3e993d6b7852c4f134441d77a4b295e8574 Gerrit-Change-Number: 63731 Gerrit-PatchSet: 2 Gerrit-Owner: Daecheol You <daecheol.you@samsung.com> Gerrit-Reviewer: Daecheol You <daecheol.you@samsung.com> Gerrit-Reviewer: Jason Lowe-Power <jason@lowepower.com> Gerrit-Reviewer: Jason Lowe-Power <power.jg@gmail.com> Gerrit-Reviewer: Tiago Muck <tiago.muck@arm.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com> Gerrit-MessageType: merged