gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[hotfix-v23-0-0-1]: dev-amdgpu: Add missing 'overrides'

BB
Bobby Bruce (Gerrit)
Mon, Jul 10, 2023 8:46 PM

Bobby Bruce has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/72224?usp=email )

Change subject: dev-amdgpu: Add missing 'overrides'
......................................................................

dev-amdgpu: Add missing 'overrides'

This causes warnings/errors in some compilers.

Change-Id: I36a3548943c030d2578c2f581c8985c12eaeb0ae

M src/arch/amdgpu/vega/insts/instructions.hh
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/arch/amdgpu/vega/insts/instructions.hh
b/src/arch/amdgpu/vega/insts/instructions.hh
index d45a84c..0e4ec04 100644
--- a/src/arch/amdgpu/vega/insts/instructions.hh
+++ b/src/arch/amdgpu/vega/insts/instructions.hh
@@ -31534,8 +31534,8 @@
} // getOperandSize

      void execute(GPUDynInstPtr) override;
  •    void initiateAcc(GPUDynInstPtr gpuDynInst);
    
  •    void completeAcc(GPUDynInstPtr gpuDynInst);
    
  •    void initiateAcc(GPUDynInstPtr gpuDynInst) override;
    
  •    void completeAcc(GPUDynInstPtr gpuDynInst) override;
    }; // Inst_DS__DS_OR_B32
    
    class Inst_DS__DS_XOR_B32 : public Inst_DS
    

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/72224?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: public/gem5
Gerrit-Branch: hotfix-v23-0-0-1
Gerrit-Change-Id: I36a3548943c030d2578c2f581c8985c12eaeb0ae
Gerrit-Change-Number: 72224
Gerrit-PatchSet: 1
Gerrit-Owner: Bobby Bruce bbruce@ucdavis.edu

Bobby Bruce has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/72224?usp=email ) Change subject: dev-amdgpu: Add missing 'overrides' ...................................................................... dev-amdgpu: Add missing 'overrides' This causes warnings/errors in some compilers. Change-Id: I36a3548943c030d2578c2f581c8985c12eaeb0ae --- M src/arch/amdgpu/vega/insts/instructions.hh 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/arch/amdgpu/vega/insts/instructions.hh b/src/arch/amdgpu/vega/insts/instructions.hh index d45a84c..0e4ec04 100644 --- a/src/arch/amdgpu/vega/insts/instructions.hh +++ b/src/arch/amdgpu/vega/insts/instructions.hh @@ -31534,8 +31534,8 @@ } // getOperandSize void execute(GPUDynInstPtr) override; - void initiateAcc(GPUDynInstPtr gpuDynInst); - void completeAcc(GPUDynInstPtr gpuDynInst); + void initiateAcc(GPUDynInstPtr gpuDynInst) override; + void completeAcc(GPUDynInstPtr gpuDynInst) override; }; // Inst_DS__DS_OR_B32 class Inst_DS__DS_XOR_B32 : public Inst_DS -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/72224?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: public/gem5 Gerrit-Branch: hotfix-v23-0-0-1 Gerrit-Change-Id: I36a3548943c030d2578c2f581c8985c12eaeb0ae Gerrit-Change-Number: 72224 Gerrit-PatchSet: 1 Gerrit-Owner: Bobby Bruce <bbruce@ucdavis.edu>