gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: misc: Include body in check for Change-Id

MJ
Melissa Jost (Gerrit)
Mon, Jul 10, 2023 9:40 PM

Melissa Jost has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/72229?usp=email )

Change subject: misc: Include body in check for Change-Id
......................................................................

misc: Include body in check for Change-Id

Updates ci-tests.yaml to check the entire commit message for
the Change-Id, not just the subject.

Change-Id: Ia76c77d096617a6fe76ffea7f2bd8a4295ca14f7

M .github/workflows/ci-tests.yaml
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.github/workflows/ci-tests.yaml
b/.github/workflows/ci-tests.yaml
index 520767b..c184e48 100644
--- a/.github/workflows/ci-tests.yaml
+++ b/.github/workflows/ci-tests.yaml
@@ -29,7 +29,7 @@
# loop through all the commits in the pull request
for commit in $(git rev-list ${{
github.event.pull_request.base.sha }}..${{
github.event.pull_request.head.sha }}); do
git checkout $commit

  •          if (git log -1 --pretty=format:"%s" | grep -q "Change-Id: ")
    
  •          if (git log -1 --pretty=format:"%B" | grep -q "Change-Id: ")
              then
                # passes as long as at least one change-id exists in the  
    

pull request
exit 0

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/72229?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email

Gerrit-MessageType: newchange
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ia76c77d096617a6fe76ffea7f2bd8a4295ca14f7
Gerrit-Change-Number: 72229
Gerrit-PatchSet: 1
Gerrit-Owner: Melissa Jost melissakjost@gmail.com

Melissa Jost has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/72229?usp=email ) Change subject: misc: Include body in check for Change-Id ...................................................................... misc: Include body in check for Change-Id Updates ci-tests.yaml to check the entire commit message for the Change-Id, not just the subject. Change-Id: Ia76c77d096617a6fe76ffea7f2bd8a4295ca14f7 --- M .github/workflows/ci-tests.yaml 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-tests.yaml b/.github/workflows/ci-tests.yaml index 520767b..c184e48 100644 --- a/.github/workflows/ci-tests.yaml +++ b/.github/workflows/ci-tests.yaml @@ -29,7 +29,7 @@ # loop through all the commits in the pull request for commit in $(git rev-list ${{ github.event.pull_request.base.sha }}..${{ github.event.pull_request.head.sha }}); do git checkout $commit - if (git log -1 --pretty=format:"%s" | grep -q "Change-Id: ") + if (git log -1 --pretty=format:"%B" | grep -q "Change-Id: ") then # passes as long as at least one change-id exists in the pull request exit 0 -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/72229?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings?usp=email Gerrit-MessageType: newchange Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ia76c77d096617a6fe76ffea7f2bd8a4295ca14f7 Gerrit-Change-Number: 72229 Gerrit-PatchSet: 1 Gerrit-Owner: Melissa Jost <melissakjost@gmail.com>