gem5-dev@gem5.org

The gem5 Developer List

View all threads

[M] Change in gem5/gem5[develop]: tests: Remove 'test_build' from the testlib

BB
Bobby Bruce (Gerrit)
Thu, Sep 15, 2022 7:06 PM

Bobby Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/63334?usp=email )

Change subject: tests: Remove 'test_build' from the testlib
......................................................................

tests: Remove 'test_build' from the testlib

These gem5 builds are compiled automatically if required by a test.
Additionally, they are redundant given the existance of the compiler
tests, run daily.

Change-Id: I71141f82a86538a77384e684b9d261794e103b99
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/63334
Tested-by: kokoro noreply+kokoro@google.com
Reviewed-by: Bobby Bruce bbruce@ucdavis.edu
Maintainer: Bobby Bruce bbruce@ucdavis.edu

D tests/gem5/test_build/test_build.py
1 file changed, 17 insertions(+), 55 deletions(-)

Approvals:
Bobby Bruce: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass

diff --git a/tests/gem5/test_build/test_build.py
b/tests/gem5/test_build/test_build.py
deleted file mode 100644
index a9b0c16..0000000
--- a/tests/gem5/test_build/test_build.py
+++ /dev/null
@@ -1,55 +0,0 @@
-# Copyright (c) 2018 The Regents of the University of California.
-# All rights reserved.
-#
-# Redistribution and use in source and binary forms, with or without
-# modification, are permitted provided that the following conditions are
-# met: redistributions of source code must retain the above copyright
-# notice, this list of conditions and the following disclaimer;
-# redistributions in binary form must reproduce the above copyright
-# notice, this list of conditions and the following disclaimer in the
-# documentation and/or other materials provided with the distribution;
-# neither the name of the copyright holders nor the names of its
-# contributors may be used to endorse or promote products derived from
-# this software without specific prior written permission.
-#
-# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
-# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
-# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
-# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
-# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
-# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
-# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
-# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
-# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

-"""
-Test file for simply building gem5
-"""
-import re
-import os
-from testlib import *

-common_isas = [constants.vega_x86_tag, constants.arm_tag,
constants.riscv_tag]
-skipped_isas = {constants.null_tag, constants.all_compiled_tag}

-for isa in constants.supported_isas:

  • if isa in skipped_isas:
  •    continue
    
  • for variant in constants.supported_variants:
  •    if isa in common_isas:
    
  •        length = constants.quick_tag
    
  •    else:
    
  •        length = constants.long_tag
    
  •    tags = [isa, length, variant]
    
  •    name = "build-{isa}-{var}".format(isa=isa, var=variant)
    
  •    fixture = Gem5Fixture(isa, variant)
    
  •    function = TestFunction(
    
  •        lambda fixtures: True, name, fixtures=[fixture]
    
  •    )
    
  •    TestSuite(name=name, tests=[function], tags=tags)
    

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/63334?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I71141f82a86538a77384e684b9d261794e103b99
Gerrit-Change-Number: 63334
Gerrit-PatchSet: 4
Gerrit-Owner: Bobby Bruce bbruce@ucdavis.edu
Gerrit-Reviewer: Bobby Bruce bbruce@ucdavis.edu
Gerrit-Reviewer: kokoro noreply+kokoro@google.com
Gerrit-MessageType: merged

Bobby Bruce has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/63334?usp=email ) Change subject: tests: Remove 'test_build' from the testlib ...................................................................... tests: Remove 'test_build' from the testlib These gem5 builds are compiled automatically if required by a test. Additionally, they are redundant given the existance of the compiler tests, run daily. Change-Id: I71141f82a86538a77384e684b9d261794e103b99 Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/63334 Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu> Maintainer: Bobby Bruce <bbruce@ucdavis.edu> --- D tests/gem5/test_build/test_build.py 1 file changed, 17 insertions(+), 55 deletions(-) Approvals: Bobby Bruce: Looks good to me, approved; Looks good to me, approved kokoro: Regressions pass diff --git a/tests/gem5/test_build/test_build.py b/tests/gem5/test_build/test_build.py deleted file mode 100644 index a9b0c16..0000000 --- a/tests/gem5/test_build/test_build.py +++ /dev/null @@ -1,55 +0,0 @@ -# Copyright (c) 2018 The Regents of the University of California. -# All rights reserved. -# -# Redistribution and use in source and binary forms, with or without -# modification, are permitted provided that the following conditions are -# met: redistributions of source code must retain the above copyright -# notice, this list of conditions and the following disclaimer; -# redistributions in binary form must reproduce the above copyright -# notice, this list of conditions and the following disclaimer in the -# documentation and/or other materials provided with the distribution; -# neither the name of the copyright holders nor the names of its -# contributors may be used to endorse or promote products derived from -# this software without specific prior written permission. -# -# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS -# "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT -# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR -# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT -# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, -# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT -# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, -# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY -# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT -# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE -# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. - -""" -Test file for simply building gem5 -""" -import re -import os -from testlib import * - -common_isas = [constants.vega_x86_tag, constants.arm_tag, constants.riscv_tag] -skipped_isas = {constants.null_tag, constants.all_compiled_tag} - -for isa in constants.supported_isas: - if isa in skipped_isas: - continue - - for variant in constants.supported_variants: - if isa in common_isas: - length = constants.quick_tag - else: - length = constants.long_tag - - tags = [isa, length, variant] - - name = "build-{isa}-{var}".format(isa=isa, var=variant) - fixture = Gem5Fixture(isa, variant) - - function = TestFunction( - lambda fixtures: True, name, fixtures=[fixture] - ) - TestSuite(name=name, tests=[function], tags=tags) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/63334?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I71141f82a86538a77384e684b9d261794e103b99 Gerrit-Change-Number: 63334 Gerrit-PatchSet: 4 Gerrit-Owner: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com> Gerrit-MessageType: merged