gem5-dev@gem5.org

The gem5 Developer List

View all threads

[XS] Change in gem5/gem5[develop]: arch: Add setRegOperand in VecRegOperand

BB
Bobby Bruce (Gerrit)
Mon, Jul 10, 2023 10:59 PM

Bobby Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/67292?usp=email )

Change subject: arch: Add setRegOperand in VecRegOperand
......................................................................

arch: Add setRegOperand in VecRegOperand

VecRegOperand also need setRegOperand method to write back execution
result.

Change-Id: Ie50606014827c14a7219558dd003eb4747231649
Co-authored-by: Xuan Hu huxuan@bosc.ac.cn
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/67292
Reviewed-by: Giacomo Travaglini giacomo.travaglini@arm.com
Reviewed-by: Bobby Bruce bbruce@ucdavis.edu
Maintainer: Giacomo Travaglini giacomo.travaglini@arm.com
Tested-by: kokoro noreply+kokoro@google.com

M src/arch/isa_parser/operand_types.py
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
Bobby Bruce: Looks good to me, approved
kokoro: Regressions pass
Giacomo Travaglini: Looks good to me, but someone else must approve;
Looks good to me, approved

diff --git a/src/arch/isa_parser/operand_types.py
b/src/arch/isa_parser/operand_types.py
index 174a54c..113cc2f 100755
--- a/src/arch/isa_parser/operand_types.py
+++ b/src/arch/isa_parser/operand_types.py
@@ -372,6 +372,7 @@

  def makeWrite(self):
      return f"""
  •    xc->setRegOperand(this, {self.dest_reg_idx},  
    

&tmp_d{self.dest_reg_idx});
if (traceData) {{
traceData->setData({self.reg_class},
&tmp_d{self.dest_reg_idx});
}}

--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/67292?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings?usp=email

Gerrit-MessageType: merged
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ie50606014827c14a7219558dd003eb4747231649
Gerrit-Change-Number: 67292
Gerrit-PatchSet: 9
Gerrit-Owner: 轩胡 huxuan0307@gmail.com
Gerrit-Reviewer: Bobby Bruce bbruce@ucdavis.edu
Gerrit-Reviewer: Gabe Black gabe.black@gmail.com
Gerrit-Reviewer: Giacomo Travaglini giacomo.travaglini@arm.com
Gerrit-Reviewer: Richard Cooper richard.cooper@arm.com
Gerrit-Reviewer: kokoro noreply+kokoro@google.com
Gerrit-CC: Roger Chang rogerycchang@google.com
Gerrit-CC: kokoro noreply+kokoro@google.com
Gerrit-CC: ksco numbksco@gmail.com

Bobby Bruce has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/67292?usp=email ) Change subject: arch: Add setRegOperand in VecRegOperand ...................................................................... arch: Add setRegOperand in VecRegOperand VecRegOperand also need setRegOperand method to write back execution result. Change-Id: Ie50606014827c14a7219558dd003eb4747231649 Co-authored-by: Xuan Hu <huxuan@bosc.ac.cn> Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/67292 Reviewed-by: Giacomo Travaglini <giacomo.travaglini@arm.com> Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu> Maintainer: Giacomo Travaglini <giacomo.travaglini@arm.com> Tested-by: kokoro <noreply+kokoro@google.com> --- M src/arch/isa_parser/operand_types.py 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Bobby Bruce: Looks good to me, approved kokoro: Regressions pass Giacomo Travaglini: Looks good to me, but someone else must approve; Looks good to me, approved diff --git a/src/arch/isa_parser/operand_types.py b/src/arch/isa_parser/operand_types.py index 174a54c..113cc2f 100755 --- a/src/arch/isa_parser/operand_types.py +++ b/src/arch/isa_parser/operand_types.py @@ -372,6 +372,7 @@ def makeWrite(self): return f""" + xc->setRegOperand(this, {self.dest_reg_idx}, &tmp_d{self.dest_reg_idx}); if (traceData) {{ traceData->setData({self.reg_class}, &tmp_d{self.dest_reg_idx}); }} -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/67292?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ie50606014827c14a7219558dd003eb4747231649 Gerrit-Change-Number: 67292 Gerrit-PatchSet: 9 Gerrit-Owner: 轩胡 <huxuan0307@gmail.com> Gerrit-Reviewer: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Gabe Black <gabe.black@gmail.com> Gerrit-Reviewer: Giacomo Travaglini <giacomo.travaglini@arm.com> Gerrit-Reviewer: Richard Cooper <richard.cooper@arm.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com> Gerrit-CC: Roger Chang <rogerycchang@google.com> Gerrit-CC: kokoro <noreply+kokoro@google.com> Gerrit-CC: ksco <numbksco@gmail.com>