gem5-dev@gem5.org

The gem5 Developer List

View all threads

[S] Change in gem5/gem5[develop]: arch-arm: Fix format specifier in encodeAArch64SysReg panic

GT
Giacomo Travaglini (Gerrit)
Fri, Jun 24, 2022 2:03 PM

Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/60729 )

Change subject: arch-arm: Fix format specifier in encodeAArch64SysReg panic
......................................................................

arch-arm: Fix format specifier in encodeAArch64SysReg panic

The panic was using the wrong format specifier: %n instead of %d

Change-Id: I92f0be85dc24da06373cba5c20bab6de7d7b4537
Signed-off-by: Giacomo Travaglini giacomo.travaglini@arm.com
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/60729
Reviewed-by: Richard Cooper richard.cooper@arm.com
Maintainer: Andreas Sandberg andreas.sandberg@arm.com
Tested-by: kokoro noreply+kokoro@google.com
Reviewed-by: Andreas Sandberg andreas.sandberg@arm.com

M src/arch/arm/regs/misc.cc
1 file changed, 18 insertions(+), 1 deletion(-)

Approvals:
Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
Richard Cooper: Looks good to me, approved
kokoro: Regressions pass

diff --git a/src/arch/arm/regs/misc.cc b/src/arch/arm/regs/misc.cc
index 00d5501..133411b 100644
--- a/src/arch/arm/regs/misc.cc
+++ b/src/arch/arm/regs/misc.cc
@@ -1317,7 +1317,7 @@
it != idxToMiscRegNum.end()) {
return it->second;
} else {

  •    panic("Invalid MiscRegIndex: %n\n", misc_reg);
    
  •    panic("Invalid MiscRegIndex: %d\n", misc_reg);
    }
    
    }

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/60729
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I92f0be85dc24da06373cba5c20bab6de7d7b4537
Gerrit-Change-Number: 60729
Gerrit-PatchSet: 2
Gerrit-Owner: Giacomo Travaglini giacomo.travaglini@arm.com
Gerrit-Reviewer: Andreas Sandberg andreas.sandberg@arm.com
Gerrit-Reviewer: Giacomo Travaglini giacomo.travaglini@arm.com
Gerrit-Reviewer: Richard Cooper richard.cooper@arm.com
Gerrit-Reviewer: kokoro noreply+kokoro@google.com
Gerrit-MessageType: merged

Giacomo Travaglini has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/60729 ) Change subject: arch-arm: Fix format specifier in encodeAArch64SysReg panic ...................................................................... arch-arm: Fix format specifier in encodeAArch64SysReg panic The panic was using the wrong format specifier: %n instead of %d Change-Id: I92f0be85dc24da06373cba5c20bab6de7d7b4537 Signed-off-by: Giacomo Travaglini <giacomo.travaglini@arm.com> Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/60729 Reviewed-by: Richard Cooper <richard.cooper@arm.com> Maintainer: Andreas Sandberg <andreas.sandberg@arm.com> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Andreas Sandberg <andreas.sandberg@arm.com> --- M src/arch/arm/regs/misc.cc 1 file changed, 18 insertions(+), 1 deletion(-) Approvals: Andreas Sandberg: Looks good to me, approved; Looks good to me, approved Richard Cooper: Looks good to me, approved kokoro: Regressions pass diff --git a/src/arch/arm/regs/misc.cc b/src/arch/arm/regs/misc.cc index 00d5501..133411b 100644 --- a/src/arch/arm/regs/misc.cc +++ b/src/arch/arm/regs/misc.cc @@ -1317,7 +1317,7 @@ it != idxToMiscRegNum.end()) { return it->second; } else { - panic("Invalid MiscRegIndex: %n\n", misc_reg); + panic("Invalid MiscRegIndex: %d\n", misc_reg); } } -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/60729 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I92f0be85dc24da06373cba5c20bab6de7d7b4537 Gerrit-Change-Number: 60729 Gerrit-PatchSet: 2 Gerrit-Owner: Giacomo Travaglini <giacomo.travaglini@arm.com> Gerrit-Reviewer: Andreas Sandberg <andreas.sandberg@arm.com> Gerrit-Reviewer: Giacomo Travaglini <giacomo.travaglini@arm.com> Gerrit-Reviewer: Richard Cooper <richard.cooper@arm.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com> Gerrit-MessageType: merged