Bobby Bruce has submitted this change. ( https://gem5-review.googlesource.com/c/public/gem5/+/60638 ) Change subject: misc: Revert "scons: Remove -Werror for the gem5 v22.0 release" ...................................................................... misc: Revert "scons: Remove -Werror for the gem5 v22.0 release" This reverts commit 4df0d886df0412511db0efdf2c7beac37db20040. https://gem5-review.googlesource.com/c/public/gem5/+/60510 Change-Id: I0833b210c6dd46f77dc0ca0cc399e013efb2e7ca Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/60638 Maintainer: Bobby Bruce <bbruce@ucdavis.edu> Tested-by: kokoro <noreply+kokoro@google.com> Reviewed-by: Bobby Bruce <bbruce@ucdavis.edu> --- M SConstruct 1 file changed, 23 insertions(+), 0 deletions(-) Approvals: Bobby Bruce: Looks good to me, approved; Looks good to me, approved kokoro: Regressions pass diff --git a/SConstruct b/SConstruct index f1f1c64..4d91eae 100755 --- a/SConstruct +++ b/SConstruct @@ -418,6 +418,13 @@ conf.CheckLinkFlag( '-Wl,--thread-count=%d' % GetOption('num_jobs')) + # Treat warnings as errors but white list some warnings that we + # want to allow (e.g., deprecation warnings). + env.Append(CCFLAGS=['-Werror', + '-Wno-error=deprecated-declarations', + '-Wno-error=deprecated', + ]) + else: error('\n'.join(( "Don't know what compiler options to use for your compiler.", -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/60638 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I0833b210c6dd46f77dc0ca0cc399e013efb2e7ca Gerrit-Change-Number: 60638 Gerrit-PatchSet: 2 Gerrit-Owner: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Bobby Bruce <bbruce@ucdavis.edu> Gerrit-Reviewer: Jason Lowe-Power <jason@lowepower.com> Gerrit-Reviewer: kokoro <noreply+kokoro@google.com> Gerrit-MessageType: merged